Hide non-numeric fields for Math calculations - #2619

classes/helpers/FrmAppHelper.php (1)

5074-5097: Expose non‑numeric types via filter and finalize @since before release

The helper cleanly centralizes the non‑numeric field type list and matches the PR intent (hide clearly text/attachment/AI style fields from math calcs). Two follow‑ups would make this more robust:

• Allow third‑party/custom field types to participate via a filter, e.g.:

-	public static function non_numeric_field_types() {
-		return array(
+	public static function non_numeric_field_types() {
+		$types = array(
 			'text',
 			'textarea',
 			'email',
 			'url',
 			'name',
 			'phone',
 			'password',
 			'tag',
 			'address',
 			'rte',
 			'file',
 			'signature',
 			'ai',
-		);
+		);
+
+		/**
+		 * Filter the list of non-numeric field types used in math calculations.
+		 *
+		 * @since x.x
+		 *
+		 * @param array $types Non-numeric field type slugs.
+		 */
+		return apply_filters( 'frm_non_numeric_field_types', $types );
 	}

• Replace the @since x.x placeholder with the actual version number before merging so the public API is properly documented.

js/src/admin/admin.js (1)

3134-3160: Harden JSON parsing for data-exclude-non-numeric in getExcludeArray

The new math-calculation branch assumes data-exclude-non-numeric is always valid JSON. If the attribute is missing, empty, or malformed (e.g., from a PHP/template change), JSON.parse will throw and break the calc field list.

You could make this a bit more robust without changing behavior in the normal case:

-		} else if ( isMathCalc ) {
-			const nonNumericTypes = codeList.getAttribute( 'data-exclude-non-numeric' );
-			if ( nonNumericTypes ) {
-				exclude.push( ...JSON.parse( nonNumericTypes ) );
-			}
+		} else if ( isMathCalc ) {
+			const nonNumericTypes = codeList.getAttribute( 'data-exclude-non-numeric' );
+			if ( nonNumericTypes ) {
+				try {
+					const parsed = JSON.parse( nonNumericTypes );
+					if ( Array.isArray( parsed ) ) {
+						exclude.push( ...parsed );
+					}
+				} catch ( e ) {
+					// Silently ignore malformed data-exclude-non-numeric.
+				}
+			}
 		}

This keeps the new feature but avoids a hard failure if the data attribute ever diverges from the expected format.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro